Changeset 43

Timestamp:

11/13/15 22:48:28 (9 years ago)

Author:

sherbold

Message:

• fix of the CLAMI processor after clarification with the author

File:

• trunk/CrossPare/src/de/ugoe/cs/cpdp/dataprocessing/CLAMIProcessor.java (modified) (3 diffs)

trunk/CrossPare/src/de/ugoe/cs/cpdp/dataprocessing/CLAMIProcessor.java

@@ -138 +138 @@
         int violationCutoff = violationCountInterator.next();
         // now we filter the data;
+        // this is first tried with the metrics with fewest violations. if no buggy/bugfree
+        // instances remain, this is repeated with the next metrics with second fewest violations,
+        // and so on.
+        // this part is a bit unclear from the description in the paper, but I confirmed with the
+        // author that this is how they implemented it
         boolean[] cleanInstances = new boolean[data.numInstances()];
         int numCleanBuggyInstances = 0;
@@ -150 +155 @@
                 Instance currentInstance = data.get(i);
                 for (int j = 0; j < data.numAttributes(); j++) {
-                    if (j != data.classIndex() && numMetricViolations[j] <= violationCutoff) {
+                    if (j != data.classIndex() && numMetricViolations[j] == violationCutoff) {
                         if (clusterNumber[i] > medianClusterNumber) {
                             // "buggy"
@@ -180 +185 @@
         }
         while (numCleanBuggyInstances == 0 || numCleanBugfreeInstances == 0);
-        
+
         // output some interesting information to provide insights into the CLAMI model
         Console.traceln(Level.FINE, "Selected Metrics and Median-threshold: ");
-        for( int j=0 ; j<data.numAttributes(); j++) {
-            if( j!=data.classIndex() && numMetricViolations[j]<=violationCutoff ) {
+        for (int j = 0; j < data.numAttributes(); j++) {
+            if (j != data.classIndex() && numMetricViolations[j] == violationCutoff) {
                 Console.traceln(Level.FINE, "\t" + data.attribute(j).name() + ": " + medians[j]);
             }
         }
-        
+
         // finally modify the instances
         // drop the metrics (also from the testdata)
         for (int j = data.numAttributes() - 1; j >= 0; j--) {
-            if (j != data.classIndex() && numMetricViolations[j] > violationCutoff) {
+            if (j != data.classIndex() && numMetricViolations[j] != violationCutoff) {
                 data.deleteAttributeAt(j);
                 testdata.deleteAttributeAt(j);